-
Notifications
You must be signed in to change notification settings - Fork 308
Ajust makefile for a line commented by mistake #2962
Conversation
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
@marckhouzam, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
/cc @jpmcb |
Hi @marckhouzam! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Community Edition better. |
Looks good @marckhouzam. Just need to sign the CLA before merge. |
Sorry for being difficult but signing the CLA is a little tricky. This contribution is done on my behalf, but future contributions may come from my employer. I worry that if I sign the CLA using my Github account, it will apply to commits made on behalf of my employer, who won't have signed the CLA. @dvonthenen Do you know if the CLA tool properly handles contributions based on the email address used in the commit? What I mean is that if I sign the CLA with my personal email address, then make future commits with my employment email address, will the tool handle that properly? That being said, the documentation seems to say that simple changes don't require the CLA. Please see the last paragraph of https://tanzucommunityedition.io/docs/latest/contribute/contributing/#contributor-license-agreement |
Good to see you Marc! I think this qualifies as a "obvious fix" but I'll check internally with our open source folks who wrote that bot. Please hold! |
👋
I feel bad making you spend time on this. Forget it, I'll just sign the CLA with my personal email, and if I ever need to contribute on behalf of my employer, I'll figure it out then. Sorry about the hassle, I'll sign the cla tomorrow. |
Please don't apologize. We recognize this is problematic needing to go through a CLA signing process just for small updates. We really appreciate you dealing with the hassle of the extra paperwork required. |
I signed the CLA. Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@marckhouzam, VMware has approved your signed contributor license agreement. |
What this PR does / why we need it
Adjust a typo in the makefile.
Describe testing done for PR
Before the PR:
Notice the last line has a
printf
command in it.After the PR
I've also checked that
make install-tce-cli-plugins
now has the missing line of output coming from thatprintf
.Special notes for your reviewer
I did not open an issue as this was just a typo.
I also didn't sign the CLA just yet as the documentation said it was not needed for obvious fixes:
https://tanzucommunityedition.io/docs/latest/contribute/contributing/#contributor-license-agreement