Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Ajust makefile for a line commented by mistake #2962

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

Adjust a typo in the makefile.

Describe testing done for PR

Before the PR:

 $make

Targets:
  help            display help

  Build targets
  Targets for building and/or installing CLI plugins on the system.
  Append "ENVS=<os-arch>" to the end of these targets to limit the binaries built.
  e.g.: make build-all-tanzu-cli-plugins ENVS=linux-amd64
  List available at https://github.com/golang/go/blob/master/src/go/build/syslist.go

  build-tce-cli-plugins builds the CLI plugins that live in the TCE repo into the artifacts directory
  install-tce-cli-plugins builds and installs CLI plugins found in artifacts directory @printf "\n[COMPLETE] built and installed TCE-specific plugins at $${XDG_DATA_HOME}/tanzu-cli/. "
[...]

Notice the last line has a printf command in it.

After the PR

$ make

Targets:
  help            display help

  Build targets
  Targets for building and/or installing CLI plugins on the system.
  Append "ENVS=<os-arch>" to the end of these targets to limit the binaries built.
  e.g.: make build-all-tanzu-cli-plugins ENVS=linux-amd64
  List available at https://github.com/golang/go/blob/master/src/go/build/syslist.go

  build-tce-cli-plugins builds the CLI plugins that live in the TCE repo into the artifacts directory
  install-tce-cli-plugins builds and installs CLI plugins found in artifacts directory

I've also checked that make install-tce-cli-plugins now has the missing line of output coming from that printf.

Special notes for your reviewer

I did not open an issue as this was just a typo.
I also didn't sign the CLA just yet as the documentation said it was not needed for obvious fixes:
https://tanzucommunityedition.io/docs/latest/contribute/contributing/#contributor-license-agreement

Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
@marckhouzam marckhouzam requested a review from a team as a code owner January 28, 2022 17:26
@vmwclabot
Copy link

@marckhouzam, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@github-actions github-actions bot added the owner/release-eng Work executed by VMware release engineering team label Jan 28, 2022
@marckhouzam
Copy link
Contributor Author

/cc @jpmcb

@github-actions
Copy link

Hi @marckhouzam! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Community Edition better.

@dvonthenen
Copy link
Contributor

Looks good @marckhouzam. Just need to sign the CLA before merge.

@marckhouzam
Copy link
Contributor Author

Looks good @marckhouzam. Just need to sign the CLA before merge.

Sorry for being difficult but signing the CLA is a little tricky. This contribution is done on my behalf, but future contributions may come from my employer. I worry that if I sign the CLA using my Github account, it will apply to commits made on behalf of my employer, who won't have signed the CLA.

@dvonthenen Do you know if the CLA tool properly handles contributions based on the email address used in the commit? What I mean is that if I sign the CLA with my personal email address, then make future commits with my employment email address, will the tool handle that properly?

That being said, the documentation seems to say that simple changes don't require the CLA. Please see the last paragraph of https://tanzucommunityedition.io/docs/latest/contribute/contributing/#contributor-license-agreement

@jpmcb
Copy link
Contributor

jpmcb commented Jan 31, 2022

Good to see you Marc!

I think this qualifies as a "obvious fix" but I'll check internally with our open source folks who wrote that bot. Please hold!

@marckhouzam
Copy link
Contributor Author

Good to see you Marc!

👋

I think this qualifies as a "obvious fix" but I'll check internally with our open source folks who wrote that bot. Please hold!

I feel bad making you spend time on this. Forget it, I'll just sign the CLA with my personal email, and if I ever need to contribute on behalf of my employer, I'll figure it out then.

Sorry about the hassle, I'll sign the cla tomorrow.

@stmcginnis
Copy link
Contributor

I feel bad making you spend time on this.

Please don't apologize. We recognize this is problematic needing to go through a CLA signing process just for small updates. We really appreciate you dealing with the hassle of the extra paperwork required.

@marckhouzam
Copy link
Contributor Author

I signed the CLA. Thanks for your patience.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stmcginnis stmcginnis merged commit 7d694d2 into vmware-tanzu:main Feb 2, 2022
@vmwclabot
Copy link

@marckhouzam, VMware has approved your signed contributor license agreement.

@marckhouzam marckhouzam deleted the fix/make branch April 20, 2022 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
owner/release-eng Work executed by VMware release engineering team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants