This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
package/external-dns: Ensure external-dns e2e test deploys correct version of package #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
christianang
force-pushed
the
external-dns-e2e-versioning
branch
from
9acb09e
to
8de4d74
Compare
christianang
force-pushed
the
external-dns-e2e-versioning
branch
3 times, most recently
from
82dcc82
to
6cba350
Compare
- previously the external-dns test would assume there was only one version of the package on the cluster and that would be the correct version to test. This checks the versions of the available packages and picks the correct version to test, ensuring the correct version is tested and allowing multiple versions of the package to be available and tested at the same time. Co-authored-by: Tyler Schultz <tschultz@vmware.com> Signed-off-by: Christian Ang <angc@vmware.com>
Signed-off-by: Christian Ang <angc@vmware.com>
flawedmatrix
force-pushed
the
external-dns-e2e-versioning
branch
from
3f08913
to
7100c01
Compare
- This allows us to run ginkgo using go run so a developer doesn't actually need ginkgo installed and our go mod has the depenedencies necessary for ginkgo to run. Signed-off-by: Christian Ang <angc@vmware.com> Co-authored-by: Edwin Xie <exie@vmware.com>
flawedmatrix
force-pushed
the
external-dns-e2e-versioning
branch
from
7100c01
to
b6d4956
Compare
|
@dvonthenen or @joshrosso once this PR is merged I think we can reenable the the external-dns unit test workflow. It adds the ginkgo cli as a dependency, which should stop the ci complaining about the go sum. |
|
@vmware-tanzu/tce-owners can I get a review on this? Thanks! |
dvonthenen
approved these changes
Feb 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Previously the external-dns test would assume there was only one version of the package on the cluster and that would be the correct version to test. This checks the versions of the available packages and picks the correct version to test, ensuring the correct version is tested and allowing multiple versions of the package to be available and tested at the same time.
This also updates ginkgo/gomega libraries and also adds the ginkgo cli as a dependency. This ensures that the go.sum contains the dependencies of the ginkgo cli and allows us to run
go run github.com/onsi/ginkgo/ginkgoin the Makefile.Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
n/a
Describe testing done for PR
Ran the external-dns e2e tests on a local cluster.
Special notes for your reviewer