Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

allow setting a dockerhub proxy for make e2e-up #83

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

adobley
Copy link

@adobley adobley commented Mar 1, 2021

Description

  • Introduced DOCKERHUB_PROXY env var to allow fetching from a mirror
    • When unset this will default to docker.io

Related Issues

Fixes #81

@adobley adobley marked this pull request as draft March 2, 2021 00:07
- Introduced DOCKERHUB_PROXY env var to allow fetching from a mirror
   - When unset this will default to `docker.io`
   - The flag will also operate on manifests during e2e tests

Co-authored-by: Aidan Obley <aobley@vmware.com>
@adobley adobley marked this pull request as ready for review March 2, 2021 00:43
Copy link
Contributor

@tylerschultz tylerschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerschultz tylerschultz merged commit 7193517 into main Mar 4, 2021
@christianang christianang deleted the allow-docker-proxy branch March 4, 2021 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developers can specify a registry for make e2e-up
3 participants