Add documentation for having separate providers #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for making these docs updates @austinbv! Looks like you'll need to rebase to pass required checks. |
|
Hmmm - this is rebased with the current master. |
|
Looks like it might want you to increment the version #.. |
Done and done |
|
unfortunately you'll have to rebase again anyway. can you also remove the .patch file that got added? Thanks! |
Documentation in the `values.yaml` to make clear having separate providers for `volumeSnapshotLocation`, `backupStorageLocation`, and the `deployment.yaml` This fixes vmware-tanzu#97 (review) Signed-off-by: Austin Vance <austin@focusedlabs.io>
Signed-off-by: Austin Vance <austin@focusedlabs.io>
This allows the merge of vmware-tanzu#94 then merging this back to back Signed-off-by: Austin Vance <austin@focusedlabs.io>
Good to go! |
skriss
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation in the
values.yamlto make clear havingseparate providers for
volumeSnapshotLocation,backupStorageLocation, and thedeployment.yamlThis fixes #97 (review)
Signed-off-by: Austin Vance austin@focusedlabs.io