Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stable repo to the new location #202

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Jan 18, 2021

Special notes for your reviewer:

the old stable path (https://kubernetes-charts.storage.googleapis.com) does not exist anymore and was replaces to https://charts.helm.sh/stable

our pipeline is pointing to the old one as we can see here: https://github.com/vmware-tanzu/helm-charts/pull/201/checks?check_run_id=1713794402

this PR just set the new path to be used

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had worked on this before but I can't find a good way to tackling it.

Thank you providing this simple solution.

@jenting
Copy link
Collaborator

jenting commented Jan 19, 2021

@carlisia Could you please review this first, thank you.

Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

@carlisia carlisia merged commit 193c62a into vmware-tanzu:main Jan 20, 2021
@cpanato cpanato deleted the fix_repo branch January 20, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants