Add podLabels to velero deployment template #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joffrey Janiec <jjaniec@student.42.fr>
jenting
reviewed
Mar 2, 2020
Comment on lines
+26
to
+28
| {{- if .Values.podLabels }} | ||
| {{- toYaml .Values.podLabels | nindent 8 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Recommends adding pod labels to restic daemonset also.
Signed-off-by: Joffrey Janiec <jjaniec@student.42.fr>
jenting
reviewed
Mar 17, 2020
Comment on lines
+193
to
+198
| # Annotations to add to the Restic daemonset's pod template. Optional. | ||
| # | ||
| # If using kube2iam or kiam, use the following annotation with your AWS_ACCOUNT_ID | ||
| # and RESTIC_ROLE_NAME filled in: | ||
| # iam.amazonaws.com/role: arn:aws:iam::<AWS_ACCOUNT_ID>:role/<RESTIC_ROLE_NAME> | ||
| podAnnotations: {} |
There was a problem hiding this comment.
What's the difference to this https://github.com/vmware-tanzu/helm-charts/blob/1e74a1b/charts/velero/values.yaml#L12-L17?
The purpose is to separate the role of restic and velero?
|
The #120 addressed add podLabels to Velero deployment and restic DaemonSet, so close this one. |
ndegory
pushed a commit
to ndegory/helm-charts
that referenced
this pull request
Jul 12, 2021
…re-tanzu#66) * set rbac api version with template rbac.apiVersion Signed-off-by: Jorrit Salverda <jsalverda@travix.com> * bump chart version to 11.14.0 Signed-off-by: Jorrit Salverda <jsalverda@travix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to set own pod labels to velero deployment template
Signed-off-by: Joffrey Janiec jjaniec@student.42.fr