Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout chart-testing parameter #85

Merged
merged 1 commit into from Mar 25, 2020
Merged

Fix timeout chart-testing parameter #85

merged 1 commit into from Mar 25, 2020

Conversation

yurinnick
Copy link
Contributor

As I understand a new version of ct introduced in the last commit uses Helm v3 by default, which has a different --timeout argument format:

--timeout duration             time to wait for any individual Kubernetes operation (like Jobs for hooks) (default 5m0s)

Chart testing will fail like #81 until PR will be merged.

Signed-off-by: Nikolai Iurin yurinnick93@gmail.com

@yurinnick yurinnick mentioned this pull request Mar 24, 2020
Merged
@yurinnick
Fix timeout chart-testing parameter
df8b355 
Signed-off-by: Nikolai Iurin <yurinnick93@gmail.com>
@nrb nrb requested a review from cpanato March 24, 2020 15:47
nrb
nrb approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, dang. Thanks for catching that!

@nrb nrb requested a review from carlisia March 24, 2020 15:47
@c3y1huang c3y1huang mentioned this pull request Mar 25, 2020
Merged
@yurinnick
Copy link
Contributor Author

@carlisia @cpanato could you approve as well please?

@cpanato
Copy link
Contributor

cpanato commented Mar 25, 2020

thanks for that!
i going to merge this

@cpanato cpanato merged commit 7a184f2 into vmware-tanzu:master Mar 25, 2020
@yurinnick yurinnick deleted the fix-timeout branch March 25, 2020 08:57
@jenting jenting mentioned this pull request Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb approved these changes

@cpanato cpanato cpanato approved these changes

@carlisia carlisia Awaiting requested review from carlisia

Assignees
No one assigned
Labels
ci/cd P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yurinnick @cpanato @nrb