Remove global imports of lodash (#1061)

dashboard/src/actions/helpers/object.ts

@@ -1,4 +1,4 @@
-import * as _ from "lodash";
+import { isEmpty } from "lodash";
 
 // Check if all the keys of an object are empty. If any value of the
 // object is a nested object it recursively checks if the inner object
@@ -9,14 +9,14 @@ export function isEmptyDeep(obj: any): boolean {
     // but we should not consider it empty
     return false;
   }
-  if (typeof obj === "object" && !_.isEmpty(obj)) {
+  if (typeof obj === "object" && !isEmpty(obj)) {
     // Check if nested objects are empty
     // If some of the keys are not empty the result is not empty
     return !Object.keys(obj).some(k => {
       return !isEmptyDeep(obj[k]);
     });
   }
-  return _.isEmpty(obj);
+  return isEmpty(obj);
 }
 
 // Remove empty keys from an object (recursively)

dashboard/src/components/AppView/AppView.tsx

@@ -1,6 +1,6 @@
 import { RouterAction } from "connected-react-router";
 import * as yaml from "js-yaml";
-import * as _ from "lodash";
+import { assignWith, isEqual } from "lodash";
 import * as React from "react";
 
 import AccessURLTable from "../../containers/AccessURLTableContainer";
@@ -108,7 +108,7 @@ class AppView extends React.Component<IAppViewProps, IAppViewState> {
     // Filter out elements in the manifest that does not comply
     // with { kind: foo }
     manifest = manifest.filter(r => r && r.kind);
-    if (!_.isEqual(manifest, this.state.manifest)) {
+    if (!isEqual(manifest, this.state.manifest)) {
       this.setState({ manifest });
     } else {
       return;
@@ -236,7 +236,7 @@ class AppView extends React.Component<IAppViewProps, IAppViewState> {
         // A List can contain an arbitrary set of resources so we treat them as an
         // additional manifest. We merge the current result with the resources of
         // the List, concatenating items from both.
-        _.assignWith(
+        assignWith(
           result,
           this.parseResources((i as IK8sList<IResource, {}>).items, releaseNamespace),
           // Merge the list with the current result

dashboard/src/components/AppView/SecretsTable/SecretsTable.tsx

@@ -1,4 +1,3 @@
-import * as _ from "lodash";
 import * as React from "react";
 
 import ResourceRef from "shared/ResourceRef";

dashboard/src/components/AppView/helpers/index.ts

@@ -1,7 +1,7 @@
-import * as _ from "lodash";
+import { some } from "lodash";
 
 import { IKubeItem } from "./../../../shared/types";
 
 export default function isSomeResourceLoading(resources: Array<IKubeItem<any>>): boolean {
-  return _.some(resources, i => i.isFetching);
+  return some(resources, i => i.isFetching);
 }

dashboard/src/components/Catalog/CatalogItem.test.tsx

@@ -1,6 +1,6 @@
 import { shallow } from "enzyme";
 import context from "jest-plugin-context";
-import * as _ from "lodash";
+import { cloneDeep } from "lodash";
 import * as React from "react";
 
 import { IChart, IRepo } from "../../shared/types";
@@ -36,7 +36,7 @@ it("should render an item", () => {
 });
 
 it("should use the default placeholder for the icon if it doesn't exist", () => {
-  const chartWithoutIcon = _.cloneDeep(defaultChart);
+  const chartWithoutIcon = cloneDeep(defaultChart);
   chartWithoutIcon.attributes.icon = undefined;
   const wrapper = shallow(<CatalogItem chart={chartWithoutIcon} />);
   // Importing an image returns "undefined"
@@ -50,7 +50,7 @@ it("should use the default placeholder for the icon if it doesn't exist", () =>
 });
 
 it("should place a dash if the version is not avaliable", () => {
-  const chartWithoutVersion = _.cloneDeep(defaultChart);
+  const chartWithoutVersion = cloneDeep(defaultChart);
   chartWithoutVersion.relationships.latestChartVersion.data.app_version = "";
   const wrapper = shallow(<CatalogItem chart={chartWithoutVersion} />);
   expect(
@@ -63,7 +63,7 @@ it("should place a dash if the version is not avaliable", () => {
 });
 
 it("show the chart description", () => {
-  const chartWithDescription = _.cloneDeep(defaultChart);
+  const chartWithDescription = cloneDeep(defaultChart);
   chartWithDescription.attributes.description = "This is a description";
   const wrapper = shallow(<CatalogItem chart={chartWithDescription} />);
   expect(
@@ -77,7 +77,7 @@ it("show the chart description", () => {
 
 context("when the description is too long", () => {
   it("trims the description", () => {
-    const chartWithDescription = _.cloneDeep(defaultChart);
+    const chartWithDescription = cloneDeep(defaultChart);
     chartWithDescription.attributes.description =
       "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vestibulum ultrices velit leo, quis pharetra mi vestibulum quis.";
     const wrapper = shallow(<CatalogItem chart={chartWithDescription} />);

dashboard/src/components/ChartView/ChartVersionsList.tsx

@@ -36,12 +36,11 @@ class ChartVersionsList extends React.Component<IChartVersionsListProps, IChartV
     return (
       <div className="ChartVersionsList">
         <ul className="remove-style padding-l-reset margin-b-reset">{items}</ul>
-        {!this.state.showAll &&
-          this.props.versions.length > 5 && (
-            <a className="type-small" onClick={this.handleShowAll}>
-              Show all...
-            </a>
-          )}
+        {!this.state.showAll && this.props.versions.length > 5 && (
+          <a className="type-small" onClick={this.handleShowAll}>
+            Show all...
+          </a>
+        )}
       </div>
     );
   }

dashboard/src/components/ServiceInstanceList/ServiceInstanceCardList.tsx

@@ -1,4 +1,4 @@
-import * as _ from "lodash";
+import { lowerFirst } from "lodash";
 import * as React from "react";
 
 import { IClusterServiceClass } from "shared/ClusterServiceClass";
@@ -48,7 +48,7 @@ const ServiceInstanceCardList: React.SFC<IServiceInstanceCardListProps> = props
                   icon={icon}
                   serviceClassName={(svcClass && svcClass.spec.externalName) || "-"}
                   servicePlanName={instance.spec.clusterServicePlanExternalName}
-                  statusReason={status && _.lowerFirst(status.reason)}
+                  statusReason={status && lowerFirst(status.reason)}
                 />
               );
             })}

dashboard/src/containers/AccessURLTableContainer/AccessURLTableContainer.tsx

@@ -1,4 +1,3 @@
-import * as _ from "lodash";
 import { connect } from "react-redux";
 import { Action } from "redux";
 import { ThunkDispatch } from "redux-thunk";

dashboard/src/containers/ApplicationStatusContainer/ApplicationStatusContainer.ts

@@ -1,4 +1,3 @@
-import * as _ from "lodash";
 import { connect } from "react-redux";
 import { Action } from "redux";
 import { ThunkDispatch } from "redux-thunk";

dashboard/src/containers/SecretItemContainer/SecretItemContainer.ts

@@ -1,4 +1,3 @@
-import * as _ from "lodash";
 import { connect } from "react-redux";
 import { Action } from "redux";
 import { ThunkDispatch } from "redux-thunk";

dashboard/src/containers/ServiceItemContainer/ServiceItemContainer.ts

@@ -1,4 +1,3 @@
-import * as _ from "lodash";
 import { connect } from "react-redux";
 import { Action } from "redux";
 import { ThunkDispatch } from "redux-thunk";

dashboard/src/containers/WorkloadItemContainer/WorkloadItemContainer.ts

@@ -1,4 +1,3 @@
-import * as _ from "lodash";
 import { connect } from "react-redux";
 import { Action } from "redux";
 import { ThunkDispatch } from "redux-thunk";

dashboard/src/containers/helpers/index.ts

@@ -1,5 +1,3 @@
-import * as _ from "lodash";
-
 import ResourceRef from "../../shared/ResourceRef";
 import { IKubeState } from "../../shared/types";
 

dashboard/src/reducers/kube.ts

@@ -1,5 +1,4 @@
 import { LOCATION_CHANGE, LocationChangeAction } from "connected-react-router";
-import * as _ from "lodash";
 
 import { getType } from "typesafe-actions";
 import actions from "../actions";