Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade flow] Store user changes as modifications #1773

Closed
andresmgot opened this issue Jun 5, 2020 · 3 comments
Closed

[Upgrade flow] Store user changes as modifications #1773

andresmgot opened this issue Jun 5, 2020 · 3 comments
Labels
component/packages Issue related to kubeapps packaging formats to be distributed (Helm chart and Carvel packages) component/ui Issue related to kubeapps UI kind/proposal An issue that reports a new feature proposal to be discussed
Milestone

Comments

@andresmgot
Copy link
Contributor

Description:

When upgrading an app, if any modification is made to the values, changing the version will have no effect. This is because in the past, we didn't have a way to differentiate between user changes and version changes. Now since we store user modifications (in the deployed version), we can also store modifications that has not been submitted yet.

Steps to reproduce the issue:

  1. Deploy an old version
  2. Click upgrade
  3. Change something in the values
  4. Change the version

Describe the results you received:

After that, the step 4 has no effect.

Describe the results you expected:

In the step 4, the changes in the values from the new version should be applied.

Additional information you deem important (e.g. issue happens only occasionally):

Version of Helm, Kubeapps and Kubernetes:

  • Output of helm list <kubeapps-release-name>:
NAME    	NAMESPACE	REVISION	UPDATED                                	STATUS  	CHART         	APP VERSION
kubeapps	kubeapps 	3       	2020-06-04 15:20:40.202571364 +0000 UTC	deployed	kubeapps-3.7.0	v1.10.1    
@stale
Copy link

stale bot commented Oct 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 2, 2020
@andresmgot andresmgot added kind/feature An issue that reports a feature (approved) to be implemented and removed wontfix labels Oct 5, 2020
@ppbaena ppbaena added component/packages Issue related to kubeapps packaging formats to be distributed (Helm chart and Carvel packages) component/ui Issue related to kubeapps UI size/M and removed priority/high labels May 7, 2021
@ppbaena ppbaena added this to the Community requests milestone Sep 24, 2021
@ppbaena ppbaena added kind/proposal An issue that reports a new feature proposal to be discussed next-iteration Issues to be discussed in planning session and removed kind/feature An issue that reports a feature (approved) to be implemented labels Jun 8, 2022
@ppbaena
Copy link
Collaborator

ppbaena commented Jun 9, 2022

To be verified.

@ppbaena ppbaena removed the next-iteration Issues to be discussed in planning session label Jul 4, 2022
@ppbaena
Copy link
Collaborator

ppbaena commented Oct 6, 2022

Closed as included in the new table view and editor (#4396) comparing default values, deployed values, and new values for the package.

@ppbaena ppbaena closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packages Issue related to kubeapps packaging formats to be distributed (Helm chart and Carvel packages) component/ui Issue related to kubeapps UI kind/proposal An issue that reports a new feature proposal to be discussed
Projects
Archived in project
Development

No branches or pull requests

2 participants