Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repos API/Helm - Analyze and migrate the former SyncJobTemplate options to the API #5128

Closed
2 tasks
antgamdia opened this issue Jul 26, 2022 · 1 comment · Fixed by #5622
Closed
2 tasks
Assignees
Labels
component/apis-server Issue related to kubeapps api-server component/apprepository Issue related to kubeapps apprepository kind/enhancement An issue that reports an enhancement for an implemented feature

Comments

@antgamdia
Copy link
Contributor

antgamdia commented Jul 26, 2022

Summary
Some of the options that can be set from the chart inside the syncJobPodTemplate are no longer available via API.
For instance, the proxy options and custom labels/annotations.

Background and rationale
After the new Repos API, the majority of the options under the syncJobPodTemplate weren't migrated. We

Description
For example:

  • Add http_proxy, https_proxy and no_proxy to the helm apprepo via API
  • Add annotation and labels to the helm apprepo's pods via API

Acceptance criteria

  • Get a list of features that are/were available vs the ones supported by the repos API.
  • For each one, decide whether to ignore it or accept it.

Additional context
IMHO, this is not urgent as, at least, users can still apply these options via chart.

@antgamdia
Copy link
Contributor Author

FTR, Greg shared a way to force a repo reconciliation in Flux. It could be useful for adding a manual "sync" button in the UI as we used to have for the Helm direct plugin in the past.

https://fluxcd.io/flux/components/source/ocirepositories/#triggering-a-reconcile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/apis-server Issue related to kubeapps api-server component/apprepository Issue related to kubeapps apprepository kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants