Kubeapps Helm AppRepository should support configurable sync interval #3661
Assignees
Labels
component/apprepository
Issue related to kubeapps apprepository
kind/feature
An issue that reports a feature (approved) to be implemented
Milestone
Comments
absoludity
added
component/apprepository
ppbaena
modified the milestones:
Technical debt, documentation & improvements,
App repository revamping
12 tasks
|
As of today, the new Repos API implementation for Helm does not support it: |
12 tasks
|
@antgamdia take a look at #5128 as it is related. |
This was referenced Nov 2, 2022
Merged
antgamdia
added a commit
that referenced
this issue
Nov 3, 2022
### Description of the change While working on #3661, I noticed some files were plenty of typos 😅 , so I squeezed some fixes in my PR. However, I gave up and ended up running an auto-fixer. This PR is adding all the occurrences of the auto-fix tool. ### Benefits No more typos for a while, hopefully. ### Possible drawbacks This is a one-time change, but we should prevent them from happening. ### Applicable issues N/A ### Additional information We could have a look at the corresponding GHA that already exists: https://github.com/marketplace/actions/typos-action Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
added a commit
that referenced
this issue
Nov 17, 2022
### Description of the change This PR is adding a new field (`Interval`) in the `AppRepository` CRD. This field will override the global default `crontab` used for every repository, which is aligned with the recent Repositories API we defined. The PR includes every required change across the components, namely: - Add `Interval` field in the CR definition. - Add this field when spinning up jobs in the `apprepository-controller` and use it; otherwise, use the default one. - Use this value in the AddRepo/UpdateRepo methods of the Repos API (Helm plugin) - Remove any workarounds preventing the UI from setting the interval in Helm repos. ### Benefits Helm repos can have customizable intervals now. ### Possible drawbacks ~IRL test is still pending. I don't know if adding a field in the CRD is breaking something, though we already added some fields in the past with no impact, but want to re-check just in case.~ ### Applicable issues - fixes #3661 ### Additional information After the IRL test, some notes: - Helm does not upgrade the CRDs, so you have to delete and install them. - If the CRD is outdated, then the interval is not being saved, falling back to the previous, classical behavior. - One caveat is that the upgrade process: since we are creating a CronJob and passing the crontab value on creation via the apprepository controller, from the Repos API we don't have a clear way to _edit_ the cronjob once generated. - In this PR we've addressed it by just disabling the field when upgrading Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Co-authored-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Currently the interval with which the helm repositories referenced by an
AppRepositoryare synced to the cache is configurable only for the apprepository controller itself (Values.apprepository.crontab), defaulting to 10minute intervals.This should be exposed as an option on the AppRepository itself so that the crontab can be specified per repository, given that different repositories have different needs.
Additional information you deem important (e.g. issue happens only occasionally):
This has come up because the new API will support an interval when creating an app repository (as supported by flux (and carvel?)). The Helm plugin/support can initially just not expose this in the UI and fail validation if specified to the API, so it's not urgent, but would be nice to have.
The text was updated successfully, but these errors were encountered: