Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching params in nested values of the JSON Schema table #5437

Closed
antgamdia opened this issue Oct 6, 2022 · 1 comment · Fixed by #5444
Closed

Allow searching params in nested values of the JSON Schema table #5437

antgamdia opened this issue Oct 6, 2022 · 1 comment · Fixed by #5444
Assignees
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature

Comments

@antgamdia
Copy link
Contributor

Summary
After #5412 is done, the param search box requires some improvements, as it only searches top-level params (not the nested ones).

Background and rationale
We just replicated the example of the new Table component we added, but we need to improve it.

Description
Allow searching nested params in the table search box.

Acceptance criteria

  • The search box is able to find nested params.

Additional context
Related to #4917

@antgamdia antgamdia added component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature labels Oct 6, 2022
@ppbaena ppbaena added the next-iteration Issues to be discussed in planning session label Oct 6, 2022
@antgamdia antgamdia self-assigned this Oct 6, 2022
@antgamdia
Copy link
Contributor Author

Unfortunately, it seems like a bug in the filtering capabilities of the dependency we're using (see TanStack/table#4190 and TanStack/table#3828), but there's an open PR aimed at fixing it (TanStack/table#4376).

However, I guess we can still work around it in the meantime. We should be able to manually iterate over the rows, and mark as "passing the filter" every parent row having a matching child.
I'm a little concerned about the performance impact, but in my IRL test I don't notice any extra and unbearable waiting time.
Will send a PR soon.

@ppbaena ppbaena removed the next-iteration Issues to be discussed in planning session label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants