Search table nested params #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
castelblanque
approved these changes
Oct 10, 2022
absoludity
pushed a commit
that referenced
this pull request
Feb 24, 2023
Bumps [axios](https://github.com/axios/axios) from 1.3.3 to 1.3.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.3.4</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>blob:</strong> added a check to make sure the Blob class is available in the browser's global scope; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5548">#5548</a>) (<a href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li> <li><strong>http:</strong> fixed regression bug when handling synchronous errors inside the adapter; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5564">#5564</a>) (<a href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+38/-26 ([#5564](axios/axios#5564) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg" title="+4/-0 ([#5548](axios/axios#5548) )">lcysgsg</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan" title="+3/-0 ([#5444](axios/axios#5444) )">Michael Di Prisco</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">1.3.4</a> (2023-02-22)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>blob:</strong> added a check to make sure the Blob class is available in the browser's global scope; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5548">#5548</a>) (<a href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li> <li><strong>http:</strong> fixed regression bug when handling synchronous errors inside the adapter; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5564">#5564</a>) (<a href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+38/-26 ([#5564](axios/axios#5564) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg" title="+4/-0 ([#5548](axios/axios#5548) )">lcysgsg</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan" title="+3/-0 ([#5444](axios/axios#5444) )">Michael Di Prisco</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/2e70cecda42993e1153248f0f96715c3c55f7f39"><code>2e70cec</code></a> chore(release): v1.3.4 (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5565">#5565</a>)</li> <li><a href="https://github.com/axios/axios/commit/cbe2de60d3c9f494b4f5996632107d7a3a93abf1"><code>cbe2de6</code></a> chore(ci): remove team-reviewers config; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5566">#5566</a>)</li> <li><a href="https://github.com/axios/axios/commit/2b1fc73600f28028499aa08c7baff980da10b504"><code>2b1fc73</code></a> chore(docs): added missing config.transport doc (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5444">#5444</a>)</li> <li><a href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a"><code>3772c8f</code></a> fix(blob): added a check to make sure the Blob class is available in the brow...</li> <li><a href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451"><code>a3b246c</code></a> fix(http): fixed regression bug when handling synchronous errors inside the a...</li> <li>See full diff in <a href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
absoludity
pushed a commit
that referenced
this pull request
Mar 16, 2023
Bumps [axios](https://github.com/axios/axios) from 1.3.3 to 1.3.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.3.4</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>blob:</strong> added a check to make sure the Blob class is available in the browser's global scope; (<a href="https://redirect.github.com/axios/axios/issues/5548">#5548</a>) (<a href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li> <li><strong>http:</strong> fixed regression bug when handling synchronous errors inside the adapter; (<a href="https://redirect.github.com/axios/axios/issues/5564">#5564</a>) (<a href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+38/-26 ([#5564](axios/axios#5564) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg" title="+4/-0 ([#5548](axios/axios#5548) )">lcysgsg</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan" title="+3/-0 ([#5444](axios/axios#5444) )">Michael Di Prisco</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">1.3.4</a> (2023-02-22)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>blob:</strong> added a check to make sure the Blob class is available in the browser's global scope; (<a href="https://redirect.github.com/axios/axios/issues/5548">#5548</a>) (<a href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li> <li><strong>http:</strong> fixed regression bug when handling synchronous errors inside the adapter; (<a href="https://redirect.github.com/axios/axios/issues/5564">#5564</a>) (<a href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+38/-26 ([#5564](axios/axios#5564) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg" title="+4/-0 ([#5548](axios/axios#5548) )">lcysgsg</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan" title="+3/-0 ([#5444](axios/axios#5444) )">Michael Di Prisco</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/2e70cecda42993e1153248f0f96715c3c55f7f39"><code>2e70cec</code></a> chore(release): v1.3.4 (<a href="https://redirect.github.com/axios/axios/issues/5565">#5565</a>)</li> <li><a href="https://github.com/axios/axios/commit/cbe2de60d3c9f494b4f5996632107d7a3a93abf1"><code>cbe2de6</code></a> chore(ci): remove team-reviewers config; (<a href="https://redirect.github.com/axios/axios/issues/5566">#5566</a>)</li> <li><a href="https://github.com/axios/axios/commit/2b1fc73600f28028499aa08c7baff980da10b504"><code>2b1fc73</code></a> chore(docs): added missing config.transport doc (<a href="https://redirect.github.com/axios/axios/issues/5444">#5444</a>)</li> <li><a href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a"><code>3772c8f</code></a> fix(blob): added a check to make sure the Blob class is available in the brow...</li> <li><a href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451"><code>a3b246c</code></a> fix(http): fixed regression bug when handling synchronous errors inside the a...</li> <li>See full diff in <a href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds a workaround while the TabStack table bug is being fixed (adding the
filterFromLeafRowsshould be enough to get what we want). We just mark a row as "passing" if it matches the search query (existing behavior) OR it has a child that matches the query (workaround)Benefits
Users will be able to search by any nested value in the table.
Possible drawbacks
I was a little reluctant to add this workaround for the performance implications I was foreseeing... but I have tested IRL and it is performing pretty well (see gif below), so I decided to to ahead.
Applicable issues
Additional information
(unedited speed)