Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase debug of helm tests #1153

Merged
merged 5 commits into from
Sep 6, 2019
Merged

Increase debug of helm tests #1153

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3dbc48d
Increase debug of helm tests
Sep 4, 2019
71ad54a
Include kubeapps logs
Sep 4, 2019
2049600
Fix permission issue
Sep 4, 2019
91b59f9
Remove verbosity in curl call
Sep 4, 2019
3d89b15
Merge branch 'master' into testDebug
Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/kubeapps/templates/tests/test-chartsvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ spec:
command:
- sh
- -c
- curl $CHARTSVC_HOST:$CHARTSVC_PORT/v1/charts | grep wordpress
- curl -v -o /tmp/output $CHARTSVC_HOST:$CHARTSVC_PORT/v1/charts && cat /tmp/output && cat /tmp/output | grep wordpress
restartPolicy: Never
2 changes: 1 addition & 1 deletion chart/kubeapps/templates/tests/test-dashboard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ spec:
command:
- sh
- -c
- curl $DASHBOARD_HOST | grep 'You need to enable JavaScript to run this app'
- curl -v -o /tmp/output $DASHBOARD_HOST && cat /tmp/output && cat /tmp/output | grep 'You need to enable JavaScript to run this app'
restartPolicy: Never
2 changes: 1 addition & 1 deletion chart/kubeapps/templates/tests/test-tiller-proxy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ spec:
command:
- sh
- -c
- "curl -ik -H \"Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)\" $TILLER_PROXY_HOST:$TILLER_PROXY_PORT/v1/releases | grep $KUBEAPPS_RELEASE"
- "curl -v -o /tmp/output -ik -H \"Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)\" $TILLER_PROXY_HOST:$TILLER_PROXY_PORT/v1/releases && cat /tmp/output && cat /tmp/output | grep $KUBEAPPS_RELEASE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these clusters are temporary, but here we may expose sensitive information to the CI logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say no because this is meant for the local cluster using kind but the same is executed for GKE and showing the headers would show a valid token for the cluster. Good catch! I am removing the -v

restartPolicy: Never
25 changes: 24 additions & 1 deletion script/e2e-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,27 @@ echo "All deployments ready. PODs:"
kubectl get pods -n kubeapps -o wide

# Run helm tests
helm test ${HELM_CLIENT_TLS_FLAGS} --cleanup kubeapps-ci
set +e

helm test ${HELM_CLIENT_TLS_FLAGS} kubeapps-ci
code=$?

set -e

if [[ "$code" != 0 ]]; then
echo "PODS status on failure"
kubectl get pods -n kubeapps
for pod in $(kubectl get po -l release=kubeapps-ci -oname -n kubeapps); do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here about exposing sensitive data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case there is nothing sensitive for the temporary cluster

echo "LOGS for pod $pod ------------"
kubectl logs -n kubeapps $pod
done;
echo
echo "LOGS for chartsvc tests --------"
kubectl logs kubeapps-ci-chartsvc-test --namespace kubeapps
echo "LOGS for tiller-proxy tests --------"
kubectl logs kubeapps-ci-tiller-proxy-test --namespace kubeapps
echo "LOGS for dashboard tests --------"
kubectl logs kubeapps-ci-dashboard-test --namespace kubeapps
fi

exit $code