New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test helm update to 3.2 #1731
Test helm update to 3.2 #1731
Conversation
sounds good, doesn't work |
Heh, yes. I've got changes locally to actually update the generated code, I'll get back to it later or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So after merging master (small conflict), CI is failing with an odd docker-related message:
So it builds and tags the images fine, but then fails to push because the docker client is too new. Have you seen something similar @andresmgot ? |
Mmh, no, maybe they (CircleCI) have updated the build image and the docker cli version but not the docker daemon (which is in a VM) :/ |
Retested today and it's working, so they've fixed the discrepancy. Thanks! |
Testing update to helm 3.2 to address #1726
This is ready for review now. The relevant changes are:
context.TODO()
throughout as we don't currently pass the context through),