Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test helm update to 3.2 #1731

Merged
merged 5 commits into from May 20, 2020
Merged

Test helm update to 3.2 #1731

merged 5 commits into from May 20, 2020

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented May 12, 2020

Testing update to helm 3.2 to address #1726

This is ready for review now. The relevant changes are:

  1. cmd/apprepository-controller/hack/update-codegen.sh: I've included instructions to simplify the process next time
  2. The signature for the k8s client changed to include a context (I've used context.TODO() throughout as we don't currently pass the context through),
  3. The test behaviour of the helm client changed, as it now creates a release record even if there are no resources to create (ie. k8s client's Create is never called), so updated the test so the client throws the error earlier (on client Bulid).

@andresmgot
Copy link
Contributor

sounds good, doesn't work

@absoludity
Copy link
Contributor Author

sounds good, doesn't work

Heh, yes. I've got changes locally to actually update the generated code, I'll get back to it later or tomorrow.

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@absoludity
Copy link
Contributor Author

So after merging master (small conflict), CI is failing with an odd docker-related message:

Successfully tagged kubeapps/dashboard-ci:build-5ec9dbd9f6450d3f15b9a612e1a9e5479eacd2d6
Error response from daemon: client version 1.40 is too new. Maximum supported API version is 1.39

Exited with code exit status 1

So it builds and tags the images fine, but then fails to push because the docker client is too new. Have you seen something similar @andresmgot ?

@andresmgot
Copy link
Contributor

So it builds and tags the images fine, but then fails to push because the docker client is too new. Have you seen something similar @andresmgot ?

Mmh, no, maybe they (CircleCI) have updated the build image and the docker cli version but not the docker daemon (which is in a VM) :/

@absoludity absoludity merged commit 65fc66e into vmware-tanzu:master May 20, 2020
@absoludity absoludity deleted the helm-3.2 branch May 20, 2020 00:44
@absoludity
Copy link
Contributor Author

Mmh, no, maybe they (CircleCI) have updated the build image and the docker cli version but not the docker daemon (which is in a VM) :/

Retested today and it's working, so they've fixed the discrepancy. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants