Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilterOptions for get available package summaries. #3038

Merged
merged 1 commit into from Jun 24, 2021

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Jun 24, 2021

Description of the change

Adds an initial FilterOptions message to the GetAvailablePackageSummariesRequest
able to handle existing filter options for direct helm..

Benefits

We can handle filter options for existing helm implementation.

Applicable issues

Additional Information

Looks like someone's editor is leaving trailing blank spaces - they're being cleaned up when I save a proto file, but it causes the generation to differ etc. Might be worth checking.

Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this msg!
I didn't notice the formatting issues, have you used any automatic linter?

@absoludity absoludity merged commit f2435ef into vmware-tanzu:master Jun 24, 2021
@absoludity absoludity deleted the filter-options branch June 24, 2021 09:18
@absoludity
Copy link
Contributor Author

Thanks for adding this msg!
I didn't notice the formatting issues, have you used any automatic linter?

Just

    "files.insertFinalNewline": true,
    "files.trimTrailingWhitespace": true,

in my VSCode settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants