Update to enable individual plugins for apis server #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
gfichtenholt
approved these changes
Jul 23, 2021
antgamdia
approved these changes
Jul 23, 2021
| - name: redis | ||
| repository: https://charts.bitnami.com/bitnami | ||
| version: 14.x.x | ||
| condition: redis.enabled |
There was a problem hiding this comment.
Wow, I wasn't aware of this helm feature. Good to know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
I noticed that currently we were always loading all plugins with no option to enable individual ones.
Given that we're planning to release initially with only the helm plugin enabled, this change updates to allow enabling specific plugins, defaulting to the helm one.
I've also updated the dependencies in the Chart.yaml, so that we don't accidentally update the upstream chart with the redis dependency.
Finally, I've set the replicaCount for redis in dev to zero (similar to what we do for postgres). Let me know if this is an issue Greg.
Benefits
Upstream changes to our chart (whether by us or the content team) should include only the helm plugin for now.
Possible drawbacks
None
Additional information
I'll annotate in line for anything I missed here.