Update create_release script

[antgamdia]

Description of the change

During our recent release, we noticed the create_script wasn't working. I did not investigate the root causes but instead opted for getting rid of plenty of ad-hoc scripts as we are leveraging the new Githuib CLI.

Benefits

Plenty of curl requests are now a single gh create release command. Simpler and clearer.

Possible drawbacks

Can't think of any, as, in fact, it wasn't working recently.

Applicable issues

• fixes publish CI workflow is not working #3566

Additional information

Here is a demo in a private repo where I tested it worked:

releaseProcess.mp4

[absoludity]

Thanks for the demo too!

[absoludity]

Nice

[absoludity]

Did you manually change this for your demo video? Wondering if it's worth having it as ?= or even defaulting to the current repo (so it works OOTB if we move repos in the future or similar).

[antgamdia]

Yep, I manually changed that for the video. Indeed, it is something I'd like to refactor in the rest of the scripts, but here I just followed the same approach.

Given that we may want the repo in the future, we'd like to have all these variables as CI vars, not hardcoded constants. I'd rather do it in a separate PR to also check whether it also happens in the rest of the scripts.

However, I wouldn't fall back to the current repo (even if it is the default behavior of the Github CLI if you don't pass the -R <repo> flag. Since the scripts are doing kind of important things (releasing, PRs, commits, ...) I feel more comfortable and confident if I explicitly see which repo is a command targeting to. I'd rather add a check and would return an error if undefined.

[absoludity]

Yep, makes sense.