Add 'GetPackageRepositories' impl #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Nov 23, 2021
| log "k8s.io/klog/v2" | ||
| ) | ||
|
|
||
| // GetPackageRepositories returns the package repositories based on the request managed by the 'kapp_controller' plugin |
There was a problem hiding this comment.
Note: we don't necessarily need this yet. We're not yet using it in the dashboard and the API is something Greg's working on in the background. We just had it initially with the kapp-controller plugin as an example, I think.
There was a problem hiding this comment.
Yep, I know, but I didn't want to remove the existing code and, given that we are gonna work on that soon, it worths the effort on using the same from/to unstructured approach, for example.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
added a commit
that referenced
this pull request
Nov 25, 2021
* Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'CreateInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'UpdateInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'DeleteInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageDetail Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong secret name in test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add targetCluster but throw an error if not matching with pkg one Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestCreateInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add basic TestUpdateInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong pkg cluster Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove populated secrets in the create test. Minor renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestDeleteInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetPackageRepositories' impl (#3792) * Add 'GetPackageRepositories' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix nil pointer Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetPackageRepositories Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Merge manually some changes Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
added a commit
that referenced
this pull request
Nov 25, 2021
…3816) * Add required files for the Carvel plugin impl (#3783) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl (#3784) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl (#3785) * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl (#3786) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl (#3785) * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageSummaries' impl (#3787) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl (#3785) * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageDetail' impl (#3788) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageDetail Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong secret name in test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl (#3785) * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'CreateInstalledPackage' impl (#3789) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'CreateInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageDetail Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong secret name in test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add targetCluster but throw an error if not matching with pkg one Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestCreateInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove populated secrets in the create test. Minor renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'UpdateInstalledPackage' impl (#3790) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'CreateInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'UpdateInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageDetail Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong secret name in test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add targetCluster but throw an error if not matching with pkg one Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestCreateInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add basic TestUpdateInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong pkg cluster Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove populated secrets in the create test. Minor renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'DeleteInstalledPackage' impl (#3791) * Add required files for the Carvel plugin impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageVersions' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetAvailablePackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageSummaries' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetInstalledPackageDetail' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'CreateInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'UpdateInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'DeleteInstalledPackage' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old tests. Fix TestGetClient test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetAvailablePackageVersions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageSummaries Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetInstalledPackageDetail Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong secret name in test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add targetCluster but throw an error if not matching with pkg one Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestCreateInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add basic TestUpdateInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong pkg cluster Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove populated secrets in the create test. Minor renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestDeleteInstalledPackage Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add 'GetPackageRepositories' impl (#3792) * Add 'GetPackageRepositories' impl Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix nil pointer Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add TestGetPackageRepositories Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Merge manually some changes Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Changes after code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix example plugin name in values.yaml Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add "try again" button in the installed pkgs view Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Initial WIP GetInstalledPackageResourceRefs Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Initial implementation of the
GetPackageRepositoriesoperationBenefits
An initial and very limited Carvel support in Kubeapps
Possible drawbacks
N/A
Applicable issues
Additional information
N/A