Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifests: specify catch-all server_name for kubeapps vhost, closes #361 #387

Merged
merged 1 commit into from Jul 5, 2018
Merged

manifests: specify catch-all server_name for kubeapps vhost, closes #361 #387

merged 1 commit into from Jul 5, 2018

Conversation

sameersbn
Copy link
Contributor

@sameersbn sameersbn commented Jul 4, 2018 •
edited

Description: The catch-all server_name directive remove's the warning message listed in #361

fixes #361

@sameersbn sameersbn requested a review from prydonius July 4, 2018 11:23
prydonius
prydonius approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prydonius prydonius merged commit 56a677c into vmware-tanzu:master Jul 5, 2018
@sameersbn sameersbn deleted the manifest-nginx-catchall branch July 17, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prydonius prydonius prydonius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nginx: [warn] conflicting server name "" on 0.0.0.0:8080, ignored
2 participants
@sameersbn @prydonius