Remove most references to shared/ResourceRef #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgamdia
approved these changes
Dec 2, 2021
| @@ -22,10 +19,4 @@ function mapStateToProps({ kube }: IStoreState, props: IAccessURLTableContainerP | |||
| }; | |||
| } | |||
There was a problem hiding this comment.
Not necessarily in this PR, but we should also get rid of the xxxxContainer.tsx in favor of just using react hooks, especially, now we have removed more logic
absoludity
force-pushed
the
3779-dashboard-2-appview
branch
from
79bd8a4
to
ab8ef43
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3779-dashboard-3-deletion-1
branch
from
da886ee
to
c1e2820
Compare
* Extract more unused actions. Signed-off-by: Michael Nelson <minelson@vmware.com> * Prettier Signed-off-by: Michael Nelson <minelson@vmware.com> * Remove no-longer-used test code. Signed-off-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When the dashboard was handling the fetching of resources directly from the k8s api server, it needed to also keep state about whether resources were namespaced, url endpoints for the resources and a bunch of other book-keeping. This is no longer necessary for the dashboard.
This PR begins the work of extracting the ResourceRef model, by removing it from the AppView and corresponding components/containers, and doing a drop-in replacement with the simpler generated ResourceRef from our protobuf message.
Benefits
Less code to maintain, simpler dashboard.
Possible drawbacks
Applicable issues
Additional information