Add proto and implementations for GetServiceAccountNames #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Dec 2, 2021
| @@ -254,6 +255,34 @@ func (s *Server) GetResources(r *v1alpha1.GetResourcesRequest, stream v1alpha1.R | |||
| return nil | |||
| } | |||
|
|
|||
| // GetResources returns the resources for an installed package. | |||
| return nil, status.Errorf(codes.Internal, "unable to get the k8s client: '%v'", err) | ||
| } | ||
|
|
||
| saList, err := typedClient.CoreV1().ServiceAccounts(namespace).List(context.TODO(), metav1.ListOptions{}) |
There was a problem hiding this comment.
We should be using the ctx that was passed in above, rather than creating a new context here?
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a prequel PR for #3883, mainly intended for generating all the resources, proto, implementation and API docs for the GetServiceAccountNames.
This operation just returns a list of service account names for a given authenticated user.
Benefits
We will be able to use this operation for retrieving the list of SAs when installing a package.
Possible drawbacks
N/A
Applicable issues
Additional information
I've also updated our API docs; as it is still a manual process... it forgot to do it in the previous release :S
Example: