-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for AddPackageRepository with TLS config #4376
Merged
gfichtenholt
merged 21 commits into
vmware-tanzu:main
from
gfichtenholt:further-fluxv2-plugin-features-29
Mar 4, 2022
Merged
Add integration test for AddPackageRepository with TLS config #4376
gfichtenholt
merged 21 commits into
vmware-tanzu:main
from
gfichtenholt:further-fluxv2-plugin-features-29
Mar 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-organize integration tests by the functionality
absoludity
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (relatively) small incremental commit that mostly just adds one integration tests for AddPackageRepository() with TLS configuration. Most of the changes are directly related to that. I also did a little bit of a re-org of integration tests so they are not all one huge file, but split up by functionality like my unit tests.