Rename App Repositories to Package Repositories
#4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
May 30, 2022
| <strong>NOTE:</strong> This App Repository will be created in the "{kubeappsNamespace}" | ||
| namespace and packages will be available in all namespaces for installation. | ||
| <strong>NOTE:</strong> This Package Repository will be created in the "{kubeappsNamespace} | ||
| " namespace and packages will be available in all namespaces for installation. |
There was a problem hiding this comment.
Won't HTML assume that new-line there is a word-break? (Not what's wanted in that situation, with the quote, I don't think?)
There was a problem hiding this comment.
No, IRL it seems it works as expected. It is a breakline introduced by the linter.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Trivial PR just renaming the old "App repo" thing to something more aligned to our concept of "package".
This is a prequel PR, but can be safely merged into main.
~
Benefits
More consistent naming.
Possible drawbacks
N/A
Applicable issues
Additional information
Let's see if the CI agrees :P
EDIT: need to look into the CI fail root cause. Will do soon.It was just a matter ofs/has-text("App Repositories")/has-text("Package Repositories")