Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minor improvements prior to the repos UI #4848

Merged
merged 6 commits into from
Jun 6, 2022
Merged

Add minor improvements prior to the repos UI #4848

merged 6 commits into from
Jun 6, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

As part of the work required for #4764, this prequel PR adds minor stuff that I can easily have taken apart from my ongoing changes. Namely:

  • Related to the Repos UI:
    • Add more information to the core API logs
    • Add more str cases in getPluginPackageName
    • Add repos api clients to KubeappsGrpcClient
  • Minor unrelated improvements
    • Handle uncaught canI rejections
    • Remove "as unknown" in some types
    • Return 0 if equals in a sort function

Benefits

Subsequent PRs will have less code to review :P

Possible drawbacks

N/A

Applicable issues

Additional information

The changes are pretty unrelated to the actual repos API things, as they are mainly improvements on other parts of the code.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Jun 6, 2022

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit f95eb6a
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/629deed0aed8e7000880693b

@castelblanque
Copy link
Collaborator

Great, thanks for the preparation work!

@antgamdia antgamdia merged commit 23e9605 into main Jun 6, 2022
@antgamdia antgamdia deleted the pkgRepo-pre2 branch June 6, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants