Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #493

Merged
merged 2 commits into from Aug 16, 2018
Merged

Update README.md #493

merged 2 commits into from Aug 16, 2018

Conversation

migmartri
Copy link
Contributor

Fix broken link

andresmgot
andresmgot reviewed Aug 16, 2018
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The same happens in chart/kubeapps/README.md there we should use links with the whole URL because that README is used in the bitnami/charts repo (I see that there is also a broken link [Role-Based Access Control](docs/user/access-control.md))

@migmartri
Copy link
Contributor Author

migmartri commented Aug 16, 2018 •
edited

Good find, fixed!

@migmartri migmartri merged commit a358a99 into master Aug 16, 2018
@migmartri migmartri deleted the migmartri-patch-1 branch August 16, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@prydonius prydonius Awaiting requested review from prydonius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@migmartri @andresmgot