Add fix for Helm charts versions ordering #4952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This bugfix tackles the issue of
GetAvailablePackageVersions
in Helm direct plugin not returning the correct versions list when the input versions are not ordered.We had all input values in our tests correctly sorted, which might not be the case on runtime.
See here.
Solution done here is to sort versions first thing in PackageAppVersionsSummary.
Benefits
Versions returned by
GetAvailablePackageVersions
should be correct now.Possible drawbacks
Solution modifies
pkgutils.PackageAppVersionsSummary
function, which applies to Flux plugin as well, although it should not break anything.Applicable issues