Minor file renames from AppRepo to PkgRepo #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
This was referenced Jun 27, 2022
antgamdia
added a commit
that referenced
this pull request
Jul 8, 2022
* wip Revamp AppRepoForm Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Update tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Allow no-commented-out-tests temporarily Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issues Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Delete AppRepository Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix repos action Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add remaining changes Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * wip fix some test cases Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix repos.ts test suite Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Implement PackageRepositoriesService test suite Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add plural names. Add packageFormat in repo list Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add AppRepoForm Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix AppRepoForm test cases Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix remaining tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove no longer used urls Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Avoid setting auth values if undefined Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix e2e tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Allow setting pullSecret in the UI. Improve CA input/secret selector Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Disable e2e test 03 Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test case Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test 03 Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Run prettier Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Minor file renames from AppRepo to PkgRepo (#4955) * Minor renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename files from AppRepo to PkgRepo Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test cases Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Comment-out e2e test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Extract regex to a const Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add some suggestions from code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix type issues in actons. Perform renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename kubeappsNamespace to globalReposNamespace Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove validation action. Fix action tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Return summaries in action to avoid full reload Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add test case for sorting when adding repo Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Disable unsupported auth methods Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Suggest pull secrets if usign docker creds Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove ad-hoc helm client Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Extract customDetails encoding to a fn Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Delete leftover Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove apprepo management from Kubeops (#5026) * Remove unused logic from kubeops Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old kubeops endpoint from api docs Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove unused kubeops args Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Address PR's comments Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Tidy up the `/pkg` folder (#5027) * Remove pkg/handlerutil Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove unused code from pkg/agent Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Move pkg/agent to plugins/pkg/agent Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add dockerjson auth type as supported to flux plg Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * cast request.customDetails to RepositoryCustomDetails Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Avoid seding mixed user/kubeapps mgn secrets Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Modify toggle msgs Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Improve secret info msg Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
added a commit
that referenced
this pull request
Aug 10, 2022
* Remove no longer used elements from AppRepoList (#4930) * Delete unused urls Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add getPluginByName to utils + imlp unit tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove unused types Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename IAppRepositoryFilter to IPkgRepositoryFilter Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove no longer used elements from AppRepoList Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Run prettier Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Revamp `AppRepoForm` (#4939) * wip Revamp AppRepoForm Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Update tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Allow no-commented-out-tests temporarily Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issues Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Switch to the new Repos API (#4954) * wip Revamp AppRepoForm Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Update tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Allow no-commented-out-tests temporarily Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issues Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Delete AppRepository Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix repos action Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add remaining changes Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * wip fix some test cases Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix repos.ts test suite Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Implement PackageRepositoriesService test suite Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add plural names. Add packageFormat in repo list Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add AppRepoForm Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix AppRepoForm test cases Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix remaining tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove no longer used urls Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Avoid setting auth values if undefined Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix e2e tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Allow setting pullSecret in the UI. Improve CA input/secret selector Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Disable e2e test 03 Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test case Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test 03 Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Run prettier Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Minor file renames from AppRepo to PkgRepo (#4955) * Minor renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename files from AppRepo to PkgRepo Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test cases Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Comment-out e2e test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Extract regex to a const Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add some suggestions from code review Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix type issues in actons. Perform renames Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename kubeappsNamespace to globalReposNamespace Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove validation action. Fix action tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Return summaries in action to avoid full reload Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add test case for sorting when adding repo Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Disable unsupported auth methods Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Suggest pull secrets if usign docker creds Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove ad-hoc helm client Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Extract customDetails encoding to a fn Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Delete leftover Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove apprepo management from Kubeops (#5026) * Remove unused logic from kubeops Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove old kubeops endpoint from api docs Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove unused kubeops args Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Address PR's comments Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Tidy up the `/pkg` folder (#5027) * Remove pkg/handlerutil Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove unused code from pkg/agent Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Move pkg/agent to plugins/pkg/agent Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add dockerjson auth type as supported to flux plg Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * cast request.customDetails to RepositoryCustomDetails Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Avoid seding mixed user/kubeapps mgn secrets Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Modify toggle msgs Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Improve secret info msg Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename the repos API's custom detail name field - 2 (#5056) * Update custom detail name with a consistent naming format Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add generated code Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Perform renames in the code Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Clean up unused vars from the pkgRepo state (#5062) * clean up unused fields and actions from repos state Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename some state fields Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename actions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Rename `customDetails` to `customDetail` (#5106) Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Minor fixes in repos UI (#5108) * Add kapp's customdetails handling Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Improvements on repo list page Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Skip building customdetail if any Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Avoid infinite loading after editing a repo Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove leftover Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix type issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Merge branch '4764-pkg-repos-ui' into minor-reposUI-fixes Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix minor rename Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add test case Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix copyright header. Ignore webmanifest files. Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test case Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add pullSecret management in repos UI (#5109) * Add imagePullSecrets option to repos API Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Regenerated code after merge from main Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Rename `customDetails` to `customDetail` Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix not found error handling. Organize imports Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add pullSecret management in repos UI Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Comment out lines Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Move secret check just when required Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Avoid passing unnecesary properties in the custom details Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix e2e tese Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix merge conflicts Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Run prettier Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix merge issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Run prettier Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix typo Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix no-case-declarations eslint issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Co-authored-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Fix merge issue Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix wrong icon path Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Enable e2e tests back (#5115) Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * add pr review suggestions Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Co-authored-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a mostly mechanic PR with a bunch of file renames moving from the old "Application Repositories" concept to the broader "Package Repositories" we are nowadays using.
Benefits
More aligned nomenclature.
Possible drawbacks
N/A
Applicable issues
Additional information
Squeezing some
apptoselectedInstalledPkgrenames.