Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifiy the mininum k8s version in the chart #4966

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

I wasn't aware that Helm allows setting the minimum k8s version until people from Content team just told me. In our case, we are relying on certain resource versions (especially, cronjobs v1 instead of v1beta, see #3846) and, when we update them, we are not backward compatible.

Benefits

We will be clear about the version we do support.

Possible drawbacks

Users won't be able to install Kubeapps on unsupported versions, which might be not ok in some cases (people working on old k8s versions not using those old resource versions, for instance, just using the flux or carvel plugin instead of the helm one).

Applicable issues

N/A

Additional information

Happy to close the PR if we don't really like the outcome as described above.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit f6dda4c
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62bc30c8fccfdc0008943d2e

@@ -2,6 +2,7 @@ annotations:
category: Infrastructure
apiVersion: v2
appVersion: DEVEL
kubeVersion: ">=1.21"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know about that parameter!

@ppbaena
Copy link
Collaborator

ppbaena commented Jun 29, 2022

I agree with this approach. From https://kubernetes.io/releases/ :

The Kubernetes project maintains release branches for the most recent three minor releases (1.24, 1.23, 1.22). Kubernetes 1.19 and newer receive approximately 1 year of patch support. Kubernetes 1.18 and older received approximately 9 months of patch support.

So in our case, setting that parameter for 1 version behind the officially version maintained by Kubernetes should be enough.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia merged commit 8da893a into vmware-tanzu:main Jun 29, 2022
@antgamdia antgamdia deleted the minK8sVersion branch June 29, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants