Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing.md #4988

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Update contributing.md #4988

merged 1 commit into from
Jul 1, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR just updates the contributing.md document to the latest vmware guidelines.

Benefits

Up to date docs.

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

N/A

@antgamdia
Update contributing.md
f0e0923 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia requested a review from ppbaena June 30, 2022 11:27
@netlify
Copy link

netlify bot commented Jun 30, 2022 •
edited

✅ Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit f0e0923
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62bd888f1c48ef0009c01426

absoludity
absoludity approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed while checking (unrelated to the change here), but our "good first issue" and "help wanted" labels are empty.

ppbaena
ppbaena approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@ppbaena ppbaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antgamdia antgamdia merged commit ba466b6 into main Jul 1, 2022
@antgamdia antgamdia deleted the contributingMd branch July 1, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absoludity absoludity absoludity approved these changes

@ppbaena ppbaena ppbaena approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@antgamdia @absoludity @ppbaena @vmwclabot