Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gosec to kubeops #4992

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Add gosec to kubeops #4992

merged 2 commits into from
Jul 1, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

After reporting #4810 , I've added the linter just in the kubeops code .
The building is gonna fail now, but if we start fixing the issues, we will be, eventually, able to merge this PR.

Benefits

Prevent new gosec issues.

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Jun 30, 2022

Deploy Preview for kubeapps-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c51f51
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62beaaa55388eb0008324f1a
😎 Deploy Preview https://deploy-preview-4992--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@castelblanque
Copy link
Collaborator

castelblanque commented Jul 1, 2022

The building is gonna fail now

It seems that CI passed fine. Is it OK like this or should have failed?

@antgamdia
Copy link
Contributor Author

It seems that CI passed fine. Is it OK like this or should have failed?

Sorry, I copy&pasted the same msg but then I didn't edit it when I added the fixes (example 2c51f51).
In short, it should have failed when I created the PR (and so it happened), but once I added the fixes, it should have passed.

@antgamdia antgamdia merged commit b26dfc7 into vmware-tanzu:main Jul 1, 2022
@antgamdia antgamdia deleted the gosec-3 branch July 1, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants