Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest of gosec issues under pkg #5001

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

antgamdia
Copy link
Contributor

Description of the change

After reporting #4810 , I've added the linter just in the pkg code .
The building is gonna fail now, but if we start fixing the issues, we will be, eventually, able to merge this PR.

Benefits

Prevent new gosec issues.

Possible drawbacks

N/A

Applicable issues

Additional information

Draft as it requires the rest of PRs to be merged.

@netlify
Copy link

netlify bot commented Jul 1, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 08381a7
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62bf0c5fb786dc00083822dd

@antgamdia antgamdia changed the base branch from main to 4764-pkg-repos-ui July 1, 2022 14:59
@antgamdia antgamdia changed the base branch from 4764-pkg-repos-ui to main July 1, 2022 15:00
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia marked this pull request as ready for review July 1, 2022 15:02
Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antgamdia antgamdia merged commit b03aab1 into vmware-tanzu:main Jul 6, 2022
@antgamdia antgamdia deleted the gosec-4 branch July 6, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle gosec issues
3 participants