-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credential info to repository summary #5003
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
The access level is a very useful information for a summary, thanks for the work! I have my doubts regarding the type used, why |
I agree, there is no need to use the What about a |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/repositories.go cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/repositories_test.go
+1 to |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Description of the change
This PR adds a slight modification to the Repos APIs: the
GetPackageRepositorySummaries
now supports an additionalauth
field. The proposed semantic is:summary.auth == nil
then the repo doesn't have any credentials.summary.auth == &corev1.PackageRepositoryAuth{}
then the repo has some sort of credentials to access it.For saving time and k8s requests, is enough to send a non-nil value. However, it can also be turned into a boolean field, but wanted to open up the discussion with you all first.
Benefits
The UI will be able to display this info without fetching the details of each repo, which could be a lengthy operation (not in this PR though, this is just a modification in the API).
Possible drawbacks
N/A
Applicable issues
Additional information