Change integration img base image #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
|
(netlify checks are failing due to #5013, but the rest are ok ) |
| @@ -21,7 +21,7 @@ spec: | |||
| - tail | |||
| - -f | |||
| - /dev/null | |||
| image: kubeapps/integration-tests:v1.1.1 | |||
| image: kubeapps/integration-tests:v2.0.0 | |||
There was a problem hiding this comment.
Small detail unrelated to this line, but to L8,L9,L13 and L17.
Given that the file has been renamed to e2e-runner, shouldn't we rename the deployment accordingly? integration seems too generic.
There was a problem hiding this comment.
Ah good idea, thanks!
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: integration/package.json integration/yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR replaces the old custom image for running the e2e test with a simpler one. It is just a just a
FROM mcr.microsoft.com/playwrightdockerfile, plus installing the browsers withnpx playwright install, as stated in the Playwright docs.Besides, this PR also renames
executor.yamltoe2e-runner.yaml.Benefits
We will rely on an official (and supported) image of Playwright. Otherwise, we would be stuck to a certain base image, as already discussed at #4206.
Possible drawbacks
N/A
Applicable issues
Additional information
Now that the image has been simplified, we should start thinking of #2792. However, the base image is pretty large (~1GB), so perhaps we should skip the
pushphase.