Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark old kubeops calls to be migrated to the resources API #5023

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR performs a quick review on the UI calls to kubeops. As this component will be deprecated soon, we should start migrating those calls to the kubeapps-apis component.
The PR just adds a comment on those calls to be migrated, as well as centralizes some sparse URLs into the url.ts file.

Benefits

Knowing what to migrate will be easier.

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7dea2b3
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62c411546896d3000983986b

Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this work, replacing the kubeops calls will be much easier.
Good job, thanks!

@antgamdia antgamdia merged commit 42c6bfd into vmware-tanzu:main Jul 5, 2022
@antgamdia antgamdia deleted the 4875-markOldKubeopsCalls branch July 5, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants