Add golangci-lint gh action #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
|
This PR is not displaying the "visual" checks because there is already failing code and, also, the PR is not adding any golang code.
Marking as a draft while we start fixing the existing issues. |
|
This is a great help. We are going to get rid of a lot of unused stuff, while keeping our source code "in shape" 😄 |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
…5060) * Fix issues in kubeops Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix issues in assety-syncer Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix isses in apprepository-controller Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
* Fix linter issues in test files Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issues Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix issues Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix errata Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
as it is just being used by an in-progress unit test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
|
Tests finally passing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR just adds
golangci-lintas a github action. We were thinking of adding this linter in building time, but perhaps the GitHub action could be also an interesting option (it adds the checks directly as annotations, so perhaps it's better, not sure yet).Benefits
Our go code will pass the linters before being merged.
Possible drawbacks
N/A
Applicable issues
Additional information
N/A