Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore clause to netlify builds #5065

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

ppbaena
Copy link
Collaborator

@ppbaena ppbaena commented Jul 12, 2022

Description of the change

Netlify builds often fail because there is no new content added to the website. It compares the cached version with the PR's (to main) content and given there are no changes, no deploy action is performed. Adding an ignore clause to netlify.toml file to prevent this situation, so builds only proceed when changes in the base directory (/site).

Benefits

  • Save some building cycles for netlify.
  • Avoid the "failed" badge for netlify on top of our readme.

Possible drawbacks

N/A

Applicable issues

Additional information

@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for kubeapps-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ee104a0
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62cd5e58b5af8b0009383b98
😎 Deploy Preview https://deploy-preview-5065--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ppbaena
Copy link
Collaborator Author

ppbaena commented Jul 12, 2022

See netlify docs and example 5 in this support question mentioning the same use case we're looking for (meaning deploy only changes inside /site folder).

@ppbaena ppbaena merged commit 9f1443e into vmware-tanzu:main Jul 12, 2022
@ppbaena ppbaena deleted the netlify/builds branch July 12, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify reporting "failed" status main's pushes when hitting a cached version
3 participants