Add imagePullSecrets option to repos API #5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 2 commits
July 15, 2022 15:12
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
12 tasks
antgamdia
reviewed
Jul 20, 2022
cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/repositories_auth.go
Outdated
Show resolved
Hide resolved
antgamdia
approved these changes
Jul 20, 2022
…auth.go Co-authored-by: Antonio Gámez, PhD <agamez@vmware.com> Signed-off-by: Rafa Castelblanque <67455978+castelblanque@users.noreply.github.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This PR changes the new package repositories API with regards to handling the images pull secret credentials in the direct Helm plugin.
Until now, the new API allowed to set such credentials by specifying the secret name only. With this PR it is now possible to do it in one of this mutually exclusive ways:
Using one way or the other still depends on the global configuration parameter
userManagedSecrets(defaults to false).Benefits
Images pull secret management is more in line with the authentication and other secrets management in the API.
Possible drawbacks
Backwards incompatibility with previous state of package repositories API, but it wasn't being used.
Applicable issues