Make repos' bearer auth prefix-safe #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
commented
Jul 19, 2022
| @@ -524,8 +524,7 @@ func (s *Server) GetInstalledPackageDetail(ctx context.Context, request *corev1. | |||
| } | |||
| } | |||
| // trim the new doc separator in the last element | |||
| //nolint:staticcheck | |||
| valuesApplied = strings.Trim(valuesApplied, "---") | |||
| valuesApplied = strings.TrimSuffix(valuesApplied, "---") | |||
There was a problem hiding this comment.
The golint gh action said we were using .Trim incorrectly: it trims chars (unicode runes), so using --- was -partially- wrong, as it wasn't removing the occurrences of the string --- but rather removing every occurrence of -.
To trim strings, we should use TrimSuffix or TrimPrefix instead (or Replace even). See https://topic.alibabacloud.com/a/the-difference-between-the-trimright-and-trimsuffix-of-the-golang-strings-package_1_38_30927804.html
Squeezing this change in this PR.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR addresses the Bearer authentication in the two plugins supporting it (Helm and Carvel) and makes the implementation "prefix-safe". Regardless of what the API client send (either
Bearer fooorfoo) the prefix will be trimmed out and the secret's content will becomeBearer foo.Benefits
The UI will be able to send the bearer token regardless of the plugin's implementation.
Possible drawbacks
N/A
Applicable issues
Additional information
I haven't changed anything related to the terminology as, in supporting both (prefixed/non-prefixed) the "token" can actually be the token and not the whole header. Anyway, happy to rename if you still think so.
Edit: squeezing some golang-ci-lint-related code; the tool (used in the gh action) got updated and new checks were being triggered. Ignoring them as it is just code used for testing.