Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed E2E tests reporting output #5141

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Fixed E2E tests reporting output #5141

merged 1 commit into from
Jul 29, 2022

Conversation

castelblanque
Copy link
Collaborator

Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com

Description of the change

E2E tests output in CI shows a red error message saying

Configuration Error: HTML reporter output folder clashes with the tests output folder:

    html reporter folder: /app/reports-html
    test results folder: /app/reports

HTML reporter will clear its output directory prior to being generated, which will lead to the artifact loss.

image

This might be due to some path pattern usage that Playwright does.
Both paths have been made different with this PR.

Benefits

E2E CI tests not display the red message about wrong report path anymore.

Possible drawbacks

N/A

Applicable issues

N/A

Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for kubeapps-dev ready!

Name Link
🔨 Latest commit 4937014
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62e2a3ef5c3b440008ea2ffa
😎 Deploy Preview https://deploy-preview-5141--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@castelblanque castelblanque merged commit 6a5ec85 into main Jul 29, 2022
@castelblanque castelblanque deleted the playwright-reports branch July 29, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants