Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubeapps.dev site #5153

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Update kubeapps.dev site #5153

merged 6 commits into from
Aug 4, 2022

Conversation

beni0888
Copy link
Collaborator

@beni0888 beni0888 commented Aug 1, 2022

Description of the change

This PR contains the following changes:

  • Updates the contributors' section.
  • Adds support for running the site locally via docker and make.

Benefits

  • Developers no longer need to install Hugo in their local machines to render kubeapps.dev site.
  • The list of contributors reflects the current state of the team

@netlify
Copy link

netlify bot commented Aug 1, 2022 •
edited

✅ Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7b43efe
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62ebd29a1d113e000c157c20

castelblanque
castelblanque reviewed Aug 2, 2022
View reviewed changes
site/README.md Outdated Show resolved Hide resolved
castelblanque
castelblanque approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the contribution.

ppbaena
ppbaena approved these changes Aug 2, 2022
View reviewed changes
site/README.md Outdated Show resolved Hide resolved
beni0888 and others added 3 commits August 3, 2022 11:58
@beni0888 @ppbaena
Reword to follow documentation style guide
f6f25e3 
Co-authored-by: Pepe Baena <ppbaena@gmail.com>
Signed-off-by: Jesús Miguel Benito Calzada <beni0888@hotmail.com>
@beni0888
Set the same Hugo version for docker and netlify
c319dd4
@beni0888
Reword an statement
6ac6f19
@beni0888
Copy link
Collaborator Author

beni0888 commented Aug 3, 2022

Already applied all suggestions. Could you please review it again? 🙏🏻

castelblanque
castelblanque approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, many thanks!!

antgamdia
antgamdia approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements here!

script/makefiles/site.mk Outdated Show resolved Hide resolved
@beni0888 @antgamdia
Fix copyright notice in script/makefiles/site.mk
7b43efe 
Co-authored-by: Antonio Gámez, PhD <antgamdia@gmail.com>
Signed-off-by: Jesús Miguel Benito Calzada <beni0888@hotmail.com>
@beni0888 beni0888 merged commit ad7a2c8 into vmware-tanzu:main Aug 4, 2022
@beni0888 beni0888 deleted the update-site branch August 4, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgamdia antgamdia antgamdia approved these changes

@ppbaena ppbaena ppbaena approved these changes

@castelblanque castelblanque castelblanque approved these changes

@dlaloue-vmware dlaloue-vmware Awaiting requested review from dlaloue-vmware

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@beni0888 @ppbaena @antgamdia @castelblanque @vmwclabot