Fixed repo mgmt buttons showing in additional clusters #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
castelblanque
commented
Aug 8, 2022
| @@ -31,3 +31,6 @@ telepresence.log | |||
|
|
|||
| # Use yarn for package management | |||
| package-lock.json | |||
|
|
|||
| # React-app proxy | |||
| src/setupProxy.js | |||
There was a problem hiding this comment.
Added the React app proxy to ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Trivial PR that fixes issue in the multicluster mode that was showing buttons for managing repos when on additional clusters. This actions are not valid in that scenario.
Those buttons are not appearing anymore in additional clusters.
Benefits
Users will not get the repository creation dialog on additional clusters -a feature not available in Kubeapps so far- and thus will not get an error when trying to create a repo.
Possible drawbacks
N/A