Flux oci support 7: unit tests for OCI support in flux plugin #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reating a clone which contents I get to manage as I see fit
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
antgamdia
approved these changes
Aug 9, 2022
| @@ -0,0 +1,122 @@ | |||
| # OCI TERMINOLOGY | |||
There was a problem hiding this comment.
This is great, and I'm really fine with this file being at this place for now, however, for leveraging the website docs rendering, we should move it eventually to site/content/docs/latest/reference/developer.
| // k8s.io/client-go >= 0.23.X | ||
| // ref https://github.com/vmware-tanzu/kubeapps/pull/5123#issuecomment-1194756900 | ||
| // I will implement once we upgrade k8s.io/client-go as stated and I can test the scenario | ||
| func (q *Type) ShutDownWithDrain() { |
There was a problem hiding this comment.
Thanks! It's great as the PR we opened in Helm has been accepted, so it is a matter of time before we can finally bump up the version.
Sure! This can happen with a little bit of work. Just a matter of prioritizing it over other things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly about adding unit tests for OCI support in flux plugin. The unit tests allow me to test the repo and chart redis cache are working as expected.
Other things in this PR:
All tests (integration+unit) passing.