Make pagination UI-driven, but based upon server's tokens #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
❌ Deploy Preview for kubeapps-dev failed.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
| @@ -149,30 +151,32 @@ export default function Catalog() { | |||
| cluster, | |||
| namespace, | |||
| reposFilter, | |||
| nextPageToken, | |||
| localNextPageToken, | |||
There was a problem hiding this comment.
Why renaming the variable? Why is important the nuance of "local"?
There was a problem hiding this comment.
Becasue nextPageToken is coming from the global packages state and localNextPageToken is a copy of this value, but in the component's state. This way, we have fine-grained control of the lifecycle of the state.
In fact, this is the crux of the PR: nextPageToken gets updated each time new data arrives (that's why it was failing).
So, technically we are not renaming but storing a local copy of nextPageToken and managing how it should be updated (that is, on each pagination event).
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: dashboard/src/components/Config/AppRepoList/AppRepoForm.tsx
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: dashboard/src/components/Catalog/Catalog.test.tsx dashboard/src/components/Catalog/Catalog.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Example of my local's vs what is currently on
mainjust accessing/#/c/default/ns/default/catalog:Benefits
Fewer initial requests and better UX, as endless pagination will work as it is expected to.
Possible drawbacks
N/A
Applicable issues
Additional information
Squeezing a minor linter-related change.