Small improvements in scripting #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antgamdia
approved these changes
Aug 10, 2022
| @@ -50,6 +52,7 @@ delete-pinniped-jwt-authenticator: | |||
| kubectl --kubeconfig=${CLUSTER_CONFIG_FOR_PINNIPED} delete -f ./site/content/docs/latest/reference/manifests/kubeapps-pinniped-jwt-authenticator.yaml | |||
| kubectl --kubeconfig=${ADDITIONAL_CLUSTER_CONFIG_FOR_PINNIPED} delete -f ./site/content/docs/latest/reference/manifests/kubeapps-pinniped-jwt-authenticator.yaml | |||
|
|
|||
| # Using old version for deletion due to error for missing secret "pinniped-concierge-impersonation-proxy" not found | |||
There was a problem hiding this comment.
Mmm, that's weird. Seems like an issue to report to our Pinniped friends, doesn't it?
There was a problem hiding this comment.
Not sure if that is a capability that they want to allow, but created issue here.
There was a problem hiding this comment.
Thanks for reporting this! Please see vmware-tanzu/pinniped#1251 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Added some improvements (e.g. variable checks) to a E2E script and the Pinniped makefile of the project.
Benefits
More robust scripts in the project, and usable from local command line too.
Possible drawbacks
N/A