Rename Pinniped Proxy TLS values in chart #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
antgamdia
approved these changes
Aug 10, 2022
chart/kubeapps/values.yaml
Outdated
Comment on lines
1589
to
1601
| ## TLS settings for Pinniped Proxy | ||
| ## @param pinnipedProxy.tls.existingSecret TLS secret with which to proxy requests | ||
| ## @param pinnipedProxy.tls.caCertificate TLS CA cert config map which clients of pinniped proxy should use with TLS requests | ||
| ## This config map must contain a ca.crt key with the CA cert content as the value. | ||
| ## | ||
| TLSSecret: "" | ||
| ## @param pinnipedProxy.CACert Specify the TLS CA cert config map which | ||
| ## clients of pinniped proxy should use with tls requests. This config map | ||
| ## must contain a ca.crt key with the CA cert content as the value. | ||
| ## | ||
| CACert: "" | ||
| ## @param pinnipedProxy.lifecycleHooks for the Pinniped Proxy container(s) to automate configuration before or after startup | ||
| tls: | ||
| ## Optional TLS secret with which to proxy requests | ||
| existingSecret: "" | ||
| ## TLS CA cert config map which clients of pinniped proxy should use with tls requests. | ||
| ## This config map must contain a ca.crt key with the CA cert content as the value. | ||
| caCertificate: "" | ||
| ## @param pinnipedProxy.lifecycleHooks For the Pinniped Proxy container(s) to automate configuration before or after startup | ||
| ## |
There was a problem hiding this comment.
What about this format? This way we avoid repeating the explanation, no?
...
defaultPinnipedAPISuffix: pinniped.dev
## TLS settings for Pinniped Proxy
## ref: https://kubeapps.dev/docs/latest/howto/oidc/using-an-oidc-provider-with-pinniped/#running-the-pinniped-proxy-service-over-tls
tls:
## @param pinnipedProxy.tls.existingSecret TLS secret with which to proxy requests
##
existingSecret: ""
## @param pinnipedProxy.tls.caCertificate TLS CA cert config map which clients of pinniped proxy should use with TLS requests
## This config map must contain a ca.crt key with the CA cert content as the value.
##
caCertificate: ""
## @param pinnipedProxy.lifecycleHooks For the Pinniped Proxy container(s) to automate configuration before or after startup
##
lifecycleHooks: {}
...There was a problem hiding this comment.
Ok, done. I thought of doing this way, but saw the blocks above in the values.yaml and all params where aggregated in the parent one. Didn't know it could be done in this way.
There was a problem hiding this comment.
I'd recall the support for these non-aggregated parms was added after we built the values.yaml, but now that it's supported, we better use it. In fact, I've double-checked it running the readmenator manually because I wasn'ts sure haha
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Renames a couple of chart values regarding TLS for Pinniped proxy.
Benefits
Kubeapps chart is in line with TLS parameters used by Bitnami.
Possible drawbacks
N/A
Applicable issues