Fix for Carvel global namespaces #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
antgamdia
approved these changes
Aug 11, 2022
Comment on lines
+11
to
+15
| // add the required polyfills (not included in webpack 5) | ||
| new NodePolyfillPlugin({ | ||
| // Allow using console.log | ||
| excludeAliases: ['console'], | ||
| }), |
There was a problem hiding this comment.
Interesting... don't know how I haven't faced this problem in my local :S
There was a problem hiding this comment.
Try removing the modules folder, lock file and yarn install maybe.
| * @param kubeappsConfig Kubeapps configuration | ||
| * @returns true if namespace is global | ||
| */ | ||
| export function isGlobalNamespace(namespace: string, pluginName: string, kubeappsConfig: IConfig) { |
There was a problem hiding this comment.
Great, thanks for the refactor here!
added 2 commits
August 11, 2022 16:23
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This PR partially addresses bug #5200 about global namespaces handling for Carvel repositories.
Benefits
It is possible now to have Carvel package repositories correctly created in the global namespace, where global repository depends on the plugin.
Listing of repositories still aggregates both global from Helm and from Carvel.
Possible drawbacks
There is still a lot of frontend code that assumes global namespace is only the one for Helm.
We need to work in the future to refactor the global namespaces part.
Applicable issues
Additional information
Follow-up work tracked in #5202