Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip re-fetching deleted installedPkgs status #5204

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

antgamdia
Copy link
Contributor

@antgamdia antgamdia commented Aug 11, 2022

Description of the change

This PR adds a check before getting the installed pkg status: "if there is not an active subscription, skip the process". This way, when unmounting components, like when we are deleting a package (we get redirected to the apps view), the fetch won't happen.

Benefits

If the app had been deleted, the fetch would have failed, showing an unpleasant error back to the user.

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Aug 11, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 58a282e
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62f522fddbc13c00086cae5e

@castelblanque
Copy link
Collaborator

Is this really blocking the release?
I'm wondering if we could leave it for the next one (patch release?).
In this way, there will be less risk for breaking new stuff. Plus the UI manual testing has already been done, and we should do another one to check regressions. WDYT?

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Copy link
Contributor Author

Is this really blocking the release?

For me, this is pretty bad, enough to block the release. I mean, see the UX right after deleting...

errordelete

Note that the function getInstalledPkgStatus is only being called at getResources, which is something scoped to the installed packages view. Worst case regression is an installed package not changing its status from "reconciling" to "ready"... but that's all. However, leaving it as is would have implications for each pkg we delete...

@antgamdia antgamdia merged commit 18c0953 into vmware-tanzu:main Aug 11, 2022
@antgamdia antgamdia deleted the fixDeletedPkgsErros branch August 11, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted applications showing an error after deletion
3 participants