Fix test environment on GKE #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
|
Tested and working in pre-release:
|
antgamdia
commented
Aug 16, 2022
Comment on lines
+312
to
+316
| # Setting up local Docker registry if not in GKE | ||
| if [[ -z "${GKE_BRANCH-}" ]]; then | ||
| setupLocalDockerRegistry | ||
| pushLocalChart | ||
| fi |
There was a problem hiding this comment.
The local docker registry doesn't work right now on GKE as the current configuration requires the k8s cert to be copied for issuing the certs. The quickest solution: ignore those tests when in GKE.
| @@ -396,7 +398,7 @@ kubectl create serviceaccount kubeapps-edit -n kubeapps | |||
| # default). See https://github.com/vmware-tanzu/kubeapps/issues/4435 | |||
| kubectl create rolebinding kubeapps-edit -n kubeapps --clusterrole=edit --serviceaccount kubeapps:kubeapps-edit | |||
| kubectl create rolebinding kubeapps-edit -n default --clusterrole=edit --serviceaccount kubeapps:kubeapps-edit | |||
| kubectl create rolebinding kubeapps-repositories-read -n kubeapps --clusterrole kubeapps:kubeapps:apprepositories-read --serviceaccount kubeapps:kubeapps-edit | |||
| kubectl create clusterrolebinding kubeapps-repositories-read --clusterrole kubeapps:kubeapps:apprepositories-read --serviceaccount kubeapps:kubeapps-edit | |||
There was a problem hiding this comment.
Changing to clusterrolebinding instead for allowing listing repos when using namespace=""
Issue tracked at #5215
ppbaena
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The local registry setup for the e2e test is not working on GKE. While finding a way to create a local registry there (main issue is dealing with certs), it's ok with disabling this test (and its setup) for now. This PR is moving the
10-xxxtest into themulticlusterfolder (which is not run when on GKE).Plus: using a clusterrolebinding for allowing listing repos from
ns=""in the EDIT user in CIBenefits
GKE tests (and therefore the release) will pass.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
N/A