Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configured plugins to the global config state #5251

Merged
merged 7 commits into from
Sep 6, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

This prequel PR is adding the currently configured plugins to the global config in the redux state. This way, the endpoint will only be called once and it will become available for the rest of the components (like the repo UI or the catalog filter)

I'll send another PR leveraging this feature to disable the plugins in the repo form.

Benefits

Info about current plugins will be available across each UI component.

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 2acfb16
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63167b76cbe9550008e34291

import { getType } from "typesafe-actions";
import actions from ".";

const mockStore = configureMockStore([thunk]);

let store: any;
const testConfig = "have you tried to turn it off and on again";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL!

Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia merged commit 0ce34d8 into main Sep 6, 2022
@antgamdia antgamdia deleted the get-plugins-from-server branch September 6, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants